8000 Fixes empty hostname returned from HostDiscoveryScript by plliao · Pull Request #3490 · horovod/horovod · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes empty hostname returned from HostDiscoveryScript #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

Fixes empty hostname returned from HostDiscoveryScript #3490

merged 2 commits into from
Mar 25, 2022

Conversation

plliao
Copy link
Contributor
@plliao plliao commented Mar 23, 2022 •
edited
Loading

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes empty hostname returned from HostDiscoveryScript and make sure hostname is not empty.

Context:
When discovery script return nothing, HostDiscoveryScript will treat the empty result i.e. "" string as the available host.
It will fail training job as launcher cannot ssh on the host with empty address. Discovery script can return nothing when no workers are available or new workers are not ready yet.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@plliao plliao force-pushed the validate_hostname_in_HostDiscoveryScript branch from 7c9593b to 21565cf Compare March 23, 2022 06:26
EnricoMi
EnricoMi requested changes Mar 23, 2022
View reviewed changes
Pei-Lun Liao added 2 commits March 23, 2022 10:53
Fixes empty hostname returned from HostDiscoveryScript
6604ce1 
Signed-off-by: Pei-Lun Liao <pliao@linkedin.com>
Add more test cases for HostDiscoveryScript
b79b7c4 
Signed-off-by: Pei-Lun Liao <pliao@linkedin.com>
@plliao plliao force-pushed the validate_hostname_in_HostDiscoveryScript branch from bfc296e to b79b7c4 Compare March 23, 2022 17:54
@github-actions
Copy link

Unit Test Results

     821 files  +  19       821 suites  +19   9h 32m 32s ⏱️ - 6m 34s
     765 tests +    8       722 ✔️ +    8       43 💤 ±0  0 ❌ ±0 
18 836 runs  +152  13 553 ✔️ +152  5 283 💤 ±0  0 ❌ ±0 

Results for commit b79b7c4. ± Comparison against base commit 80c5ba7.

@github-actions
Copy link

Unit Test Results (with flaky tests)

     905 files  +17       905 suites  +17   9h 54m 42s ⏱️ - 17m 32s
     765 tests +  8       722 ✔️ +  8       43 💤 ±0  0 ❌ ±0 
21 032 runs  +80  14 885 ✔️ +89  6 147 💤  - 9  0 ❌ ±0 

Results for commit b79b7c4. ± Comparison against base commit 80c5ba7.

@plliao plliao requested a review from EnricoMi March 24, 2022 17:38
EnricoMi
EnricoMi approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator
@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi merged commit 4b8cc49 into horovod:master Mar 25, 2022
@plliao plliao deleted the validate_hostname_in_HostDiscoveryScript branch March 25, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnricoMi EnricoMi EnricoMi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plliao @EnricoMi
0