8000 [ROCm] Fix call to hipify by ronakmal · Pull Request #3588 · horovod/horovod · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ROCm] Fix call to hipify #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2022
Merged

[ROCm] Fix call to hipify #3588

merged 1 commit into from
Jun 30, 2022

Conversation

ronakmal
Copy link
Contributor
@ronakmal ronakmal commented Jun 28, 2022 •
edited
Loading

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes #3537. There was an upstream change in hipify_python that requires absolute paths to be passed to hipify. The proposed changed also works with the older version of hipify_python.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@maxhgerlach
Copy link
Collaborator

Thank you for looking into this @ronakmal!

Could you please sign off your commit (as outlined in https://github.com/horovod/horovod/pull/3588/checks?check_run_id=7099861219) to signal that it adheres to the Developer Certificate of Origin (DCO).

@maxhgerlach maxhgerlach self-requested a review June 29, 2022 11:51
@maxhgerlach maxhgerlach mentioned this pull request Jun 29, 2022
Closed
@BeyondPerception
Correctly select files in torch/ directory to be hipified
141f41e 
Signed-off-by: Ronak Malik <Ronak.Malik@amd.com>
@ronakmal
Copy link
Contributor Author

fixed!

@github-actions
Copy link

Unit Test Results

   444 files   -    464     444 suites   - 464   6h 13m 57s ⏱️ - 3h 38m 44s
   781 tests ±       0     631 ✔️  -    106     150 💤 +   106  0 ❌ ±0 
9 643 runs   - 9 941  6 740 ✔️  - 7 208  2 903 💤  - 2 733  0 ❌ ±0 

Results for commit 141f41e. ± Comparison against base commit c7bc877.

This pull request skips 106 tests. 
test.parallel.test_adasum_pytorch.TorchAdasumTests ‑ test_orthogonal
test.parallel.test_adasum_pytorch.TorchAdasumTests ‑ test_parallel
test.parallel.test_mxnet1.MX1Tests ‑ test_gluon_trainer
test.parallel.test_mxnet1.MX1Tests ‑ test_gpu_required
test.parallel.test_mxnet1.MX1Tests ‑ test_horovod_allreduce_cpu_gpu_error
test.parallel.test_mxnet1.MX1Tests ‑ test_horovod_grouped_allreduce_cpu_gpu_error
test.parallel.test_mxnet2.MX2Tests ‑ test_allgather_object
test.parallel.test_mxnet2.MX2Tests ‑ test_broadcast_object
test.parallel.test_mxnet2.MX2Tests ‑ test_compression_fp16
test.parallel.test_mxnet2.MX2Tests ‑ test_gluon_trainer
…

@github-actions
Copy link

Unit Test Results (with flaky tests)

     472 files   -      611     472 suites   - 611   6h 17m 26s ⏱️ - 4h 18m 52s
     781 tests ±         0     631 ✔️  -    106     150 💤 +   106  0 ❌ ±0 
10 191 runs   - 13 080  7 030 ✔️  - 8 989  3 161 💤  - 4 091  0 ❌ ±0 

Results for commit 141f41e. ± Comparison against base commit c7bc877.

This pull request skips 106 tests. 
test.parallel.test_adasum_pytorch.TorchAdasumTests ‑ test_orthogonal
test.parallel.test_adasum_pytorch.TorchAdasumTests ‑ test_parallel
test.parallel.test_mxnet1.MX1Tests ‑ test_gluon_trainer
test.parallel.test_mxnet1.MX1Tests ‑ test_gpu_required
test.parallel.test_mxnet1.MX1Tests ‑ test_horovod_allreduce_cpu_gpu_error
test.parallel.test_mxnet1.MX1Tests ‑ test_horovod_grouped_allreduce_cpu_gpu_error
test.parallel.test_mxnet2.MX2Tests ‑ test_allgather_object
test.parallel.test_mxnet2.MX2Tests ‑ test_broadcast_object
test.parallel.test_mxnet2.MX2Tests ‑ test_compression_fp16
test.parallel.test_mxnet2.MX2Tests ‑ test_gluon_trainer
…

@maxhgerlach maxhgerlach merged commit b67d756 into horovod:master Jun 30, 2022
@R0n12 R0n12 mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhgerlach maxhgerlach maxhgerlach approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't pip install horovod for rocm 5.0+
3 participants
@ronakmal @maxhgerlach @BeyondPerception
0