8000 Change linking order to avoid using gloo in pytorch dynamic libraries by chengchen666 · Pull Request #3750 · horovod/horovod · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change linking order to avoid using gloo in pytorch dynamic libraries #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Change linking order to avoid using gloo in pytorch dynamic libraries #3750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion horovod/torch/CMakeLists.txt
View file
Open in desktop
5CBE
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ execute_process(COMMAND ${PY_EXE} -c "from distutils.sysconfig import get_python
OUTPUT_VARIABLE PYTHON_INCLUDE_PATH OUTPUT_STRIP_TRAILING_WHITESPACE)
include_directories(SYSTEM ${PYTHON_INCLUDE_PATH})
set(CMAKE_CXX_FLAGS "${Pytorch_COMPILE_FLAGS} ${CMAKE_CXX_FLAGS}")
list(APPEND PYTORCH_LINKER_LIBS ${Pytorch_LIBRARIES})
if(HAVE_GLOO)
if (Pytorch_CXX11)
list(APPEND PYTORCH_LINKER_LIBS gloo)
Expand All @@ -60,6 +59,7 @@ if(HAVE_ROCM)
list(APPEND PYTORCH_LINKER_LIBS compatible_horovod_cuda_kernels)
endif()
endif()
list(APPEND PYTORCH_LINKER_LIBS ${Pytorch_LIBRARIES})
parse_version(${Pytorch_VERSION} VERSION_DEC)
add_definitions(-DPYTORCH_VERSION=${VERSION_DEC} -DTORCH_API_INCLUDE_EXTENSION_H=1)
set(Pytorch_CXX11 ${Pytorch_CXX11} PARENT_SCOPE)
Expand Down
0