8000 Fix parsing Keras version identifiers like `2.2.4-tf` by maxhgerlach · Pull Request #3794 · horovod/horovod · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix parsing Keras version identifiers like 2.2.4-tf #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix parsing Keras version identifiers like 2.2.4-tf #3794

merged 1 commit into from
Dec 9, 2022

Conversation

maxhgerlach
Copy link
Collaborator
@maxhgerlach maxhgerlach commented Dec 8, 2022 •
edited
Loading

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes #3793.

This is a band-aid solution; alternatively we could switch to a more lenient version parser.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@maxhgerlach
Fix parsing Keras version identifiers like 2.2.4-tf
3d93433 
Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
chongxiaoc
chongxiaoc reviewed Dec 8, 2022
View reviewed changes
@github-actions
Copy link
github-actions bot commented Dec 8, 2022

Unit Test Results

  1 191 files  +  36    1 191 suites  +36   11h 41m 27s ⏱️ - 1h 8m 50s
     854 tests +  14       781 ✔️  -     6       53 💤 ±    0  6 ❌ +6    14 🔥 +  14 
23 127 runs   - 640  16 399 ✔️  - 582  6 617 💤  - 169  6 ❌ +6  105 🔥 +105 

For more details on these failures and errors, see this check.

Results for commit 3d93433. ± Comparison against base commit 0b19c5c.

@github-actions
Copy link
github-actions bot commented Dec 8, 2022

Unit Test Results (with flaky tests)

  1 662 files  +   255    1 662 suites  +255   13h 42m 39s ⏱️ - 19m 7s
     854 tests +     14       780 ✔️  -        6       53 💤 ±    0    7 ❌ +  6    14 🔥 +  14 
30 302 runs  +1 631  21 118 ✔️ +1 085  8 848 💤 +214  21 ❌ +17  315 🔥 +315 

For more details on these failures and errors, see this check.

Results for commit 3d93433. ± Comparison against base commit 0b19c5c.

@maxhgerlach maxhgerlach merged commit 58cb313 into master Dec 9, 2022
@maxhgerlach maxhgerlach deleted the fix-keras-version-check branch December 9, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chongxiaoc chongxiaoc chongxiaoc approved these changes

@EnricoMi EnricoMi Awaiting requested review from EnricoMi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Spark tests fail on TF 1.15 trying to parse "invalid" Keras version '2.2.4-tf'
2 participants
@maxhgerlach @chongxiaoc
0