8000 replace conda w/ pip install for horovod-nvtabular docker image by leewyang · Pull Request #3817 · horovod/horovod · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

replace conda w/ pip install for horovod-nvtabular docker image #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

replace conda w/ pip install for horovod-nvtabular docker image #3817

merged 1 commit into from
Jan 16, 2023

Conversation

leewyang
Copy link
Contributor

Signed-off-by: Lee Yang leewyang@gmail.com

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes #3797

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@leewyang
replace conda w/ pip install
a5e59be 
Signed-off-by: Lee Yang <leewyang@gmail.com>
@github-actions
Copy link

Unit Test Results

  1 155 files  ±0    1 155 suites  ±0   13h 32m 45s ⏱️ + 40m 5s
     841 tests ±0       788 ✔️ ±0       53 💤 ±0  0 ❌ ±0 
23 809 runs  ±0  17 023 ✔️ ±0  6 786 💤 ±0  0 ❌ ±0 

Results for commit a5e59be. ± Comparison against base commit bfe96f8.

@github-actions
Copy link

Unit Test Results (with flaky tests)

  1 321 files  +  26    1 321 suites  +26   14h 23m 18s ⏱️ + 52m 17s
     841 tests ±    0       787 ✔️ ±    0       53 💤 ±  0  1 ❌ ±0 
27 107 runs  +338  19 223 ✔️ +322  7 880 💤 +14  4 ❌ +2 

For more details on these failures, see this check.

Results for commit a5e59be. ± Comparison against base commit bfe96f8.

maxhgerlach
maxhgerlach approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator
@maxhgerlach maxhgerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@maxhgerlach maxhgerlach merged commit ca69f2c into horovod:master Jan 16, 2023
@leewyang leewyang deleted the nvt_docker branch January 17, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhgerlach maxhgerlach maxhgerlach approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Docker image build for horovod-nvtabular runs into time out
2 participants
@leewyang @maxhgerlach
0