Hide serialization implemenation to client apps #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
reviewed
Jul 26, 2023
Comment on lines
+76
to
+79
| // public func reply(to message: Message, with data: MessageData) { | ||
| // let replyMessage = message.replacing(data: data) | ||
| // callBridgeFunction("send", arguments: [replyMessage.toJSON()]) | ||
| // } |
There was a problem hiding this comment.
This is an interesting approach, I didn't realize that there was a reply() in the iOS library. Let's leave this commented out for now to see if we want to offer this in both the iOS and Android libraries. I do like the language that it makes it clear that you're replying to a previously handled message. I'll think about this some more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the serialization by introducing an internal
InternalMessageclass and extracts the related code from theMessage.The public
Message's data has changed from[String: AnyHashable]toString. This way we discourage users of pulling out values individually.Other changes:
InternalMessage.Message.