compile correctly with -std=c99 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables correct compilation on both MacOS and Linux using only POSIX.1-2008-compliant C with XSI extensions. Specifically, POSIX.1-2008 is the minimum version because we use strdup(3); explicit XSI is required to expose putenv from glibc.
|
Maybe the _XOPEN_SOURCE could be added to the CFLAGS instead of adding it to multiple files? Otherwise, great that you spend the time to get this done. |
|
My preference is to keep this in source (somewhere) since it is a feature macro reflecting the features of the source. Should someone mess with the build process later on, the declaration of POSIX shouldn't go away. That said, we can stick this in a config somewhere and be sure to load that before any other headers across all our source files. That may be easier to manage than sticking it in each source file that requires it. Would this be better? |
|
Yes, I believe we can move this safely to config.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables correct compilation on both MacOS and Linux using only POSIX.1-2008-compliant C with XSI extensions. It also changes the travis build to explicitly use
-std=c99to catch noncompliant patches going forward.This does not require a user compile with strict POSIX conformance though, and the general expectation is that most users will continue to build with various GNUisms enabled by default (and in fact, this is required to compile with
--with-lustre). The intent here is just to curb any creeping dependence on a specific libc or compiler.resolves #93