Iss311 test 01 02 #318
Open
Iss311 test 01 02 #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only two test cases so far: - The first test case shows the difference between GNU find and HPC dfind in handling spaces with file names. - The second test case illustrates the issue that dfind --exec does not permit standard redirection of stderr output by a command forked to exec.
These are test cases for the hpc dfind command. There are two test cases: - Check for compatibility of --exec handling spaces in filenames compared to GNU find - Check for redirection of stderr output from --exec commands which appears to fail.
I also fixed a bug with find vs. $GFIND
Testing for Issue hpc#311 Using the parameters from test_dcp/test_fiemap.sh as a starting point. The test template uses a makefile to harness the tests. Two Tests implemented: 1) Test for the correct handling of hpc dfind vs. GNU find for having blanks in file names when passing files to --exec. Only a single thread is needed to illustrate the error. 2) Test that illustrates that stderr redirection is incorrect for hpc dfind vs. GNU find. This will later be reported as a separate issue and the second test will be placed on a branch to repair that issue. Binaries under test are found in mpifileutils/../install (per normal build). Test scripts, source and destination files under ../test, e.g. ../test/bin for scripts/binaries ../test/src for test inputs ../test/dest for test output The test harness scripts accept the following parameters: -DFIND_TEST_BIN - the hpc binary under test, found in mpifileutils/../install -DFIND_MPIRUN_BIN - for mpirun vs. srun -DFIND_CMP_BIN - for the result comparison program (e.g. diff) -DFIND_SRC_DIR - for the test input files -DFIND_DEST_DIR - for the test output files -DFIND_TMP_FILE - in this case for the constructed script file -DFIND_TESTING_BIN_DIR - for the directory where test executables and scripts are placed -DFIND_TEST_NUMBER - The test number so we can re-sequence testing -GNU_FIND_BIN - The GNU binary that we use for comparison
Use the strings command to insure that we have the GNU version of the find command to test against. Also verify that the diff command came from GNU as well.
Using the parameters from test_dcp/test_fiemap.sh as a starting point.
The test template uses a makefile to harness the tests.
Two Tests implemented:
1) Test for the correct handling of hpc dfind vs. GNU find for having
blanks in file names when passing files to --exec. Only a single thread
is
needed to illustrate the error.
2) Test that illustrates that stderr redirection is incorrect for
hpc dfind vs. GNU find.
This will later be reported as a separate issue and the second test will
be placed on a branch to repair that issue.
Binaries under test are found in mpifileutils/../install (per normal
build).
Test scripts, source and destination files under ../test, e.g.
../test/bin for scripts/binaries
../test/src for test inputs
../test/dest for test output
The test harness scripts accept the following parameters:
-DFIND_TEST_BIN - the hpc binary under test, found in
mpifileutils/../install
-DFIND_MPIRUN_BIN - for mpirun vs. srun
-DFIND_CMP_BIN - for the result comparison program (e.g.
diff)
-DFIND_SRC_DIR - for the test input files
-DFIND_DEST_DIR - for the test output files
-DFIND_TMP_FILE - in this case for the constructed script
file
-DFIND_TESTING_BIN_DIR - for the directory where test
executables and scripts
are placed
-DFIND_TEST_NUMBER - The test number so we can re-sequence
testing
-GNU_FIND_BIN - The GNU binary that we use for
comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing for Issue #311
Using the parameters from test_dcp/test_fiemap.sh as a starting point.
The test template uses a makefile to harness the tests.
Two Tests implemented:
Test for the correct handling of hpc dfind vs. GNU find for having
blanks in file names when passing files to --exec. Only a single thread is
needed to illustrate the error.
Test that illustrates that stderr redirection is incorrect for
hpc dfind vs. GNU find.
This will later be reported as a separate issue and the second test will
be placed on a branch to repair that issue.
Binaries under test are found in mpifileutils/../install (per normal build).
Test scripts, source and destination files under ../test, e.g.
../test/bin for scripts/binaries
../test/src for test inputs
../test/dest for test output
The test harness scripts accept the following parameters:
-DFIND_TEST_BIN - the hpc binary under test, found in
mpifileutils/../install
-DFIND_MPIRUN_BIN - for mpirun vs. srun
-DFIND_CMP_BIN - for the result comparison program (e.g. diff)
-DFIND_SRC_DIR - for the test input files
-DFIND_DEST_DIR - for the test output files
-DFIND_TMP_FILE - in this case for the constructed script file
-DFIND_TESTING_BIN_DIR - for the directory where test executables and scripts
are placed
-DFIND_TEST_NUMBER - The test number so we can re-sequence testing
-GNU_FIND_BIN - The GNU binary that we use for comparison