8000 Added possibility to Follow/Unfollow artists via the context menu by Bettehem · Pull Request #868 · hrkfdn/ncspot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added possibility to Follow/Unfollow artists via the context menu #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Added possibility to Follow/Unfollow artists via the context menu #868

merged 3 commits into from
Jul 27, 2022

Conversation

Bettehem
Copy link
Contributor

Hello, I noticed that there was no easy way of following/unfollowing artists unless their tracks were in your library already, so I added a new option to the context menu. Now when pressing on "Show artist", you will have the option to select if you want to view the artist page or if you want to follow/unfollow the artist.

@hrkfdn
Copy link
Owner
hrkfdn commented Jul 21, 2022

Hey, thanks again. I'm not sure how intuitive it is to find this action after pressing "Show artist". I feel like this could simply be an extra item in the root section of the context menu, i.e. as "Follow artist" below "Save track". Would you be fine with this as well?

@Bettehem
Copy link
Contributor Author

Sure, I can change that!

@Bettehem
Copy link
Contributor Author

Hmm, I think it might be better behind the "Show artist" button after all. Perhaps the "Show artist" text could be changed to "Artist", or "Artists" if there are many. The problem with having the "Follow artist" text in the root section of the context menu is that if a track has multiple artists, the correct text could be "Follow" for one artist, but should be "Unfollow" for another.

@hrkfdn
Copy link
Owner
hrkfdn commented Jul 25, 2022

It could be "(Un)follow artists" with a submenu allowing you to follow or unfollow the track artists, depending on the current state. But I'm also fine with your idea, though I think we should rename it from "Show artist" to something else, as you suggested.

@Bettehem
Copy link
Contributor Author

Ok, Hello again!
I have now changed "Show Artist" to "Artist" or "Artists" if there are many. What do you think?

@hrkfdn
Copy link
Owner
hrkfdn commented Jul 27, 2022

Thanks a lot 🚀! Sorry for the delay, let's get it in!

@hrkfdn hrkfdn merged commit bba70b1 into hrkfdn:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0