fix(backtrace): Fix backtrace logging and stdout #988
Conversation
- Add manual implementation for panic that logs backtrace to a file.
- Remove all manual output to stdout.
- Fix new clippy warnings from Rust 1.65.
- Add manual implementation for panic that logs backtrace to a file. - Remove all manual output to stdout. - Fix new clippy warnings from Rust 1.65.
|
This is a small quality of life commit that tries to fix stdout. Since Cursive controls the tty, ncspot can't reliably print backtraces or other information to it. Therefore it's better to print that information to a file instead. I also removed the message that was displayed at startup, since it also showed some weird behavior (I think it tried to print with a <LF> on linux, but in raw mode, the terminal only moves down, and not to the beginning. After going back out of Raw mode, it doesn't find a valid <CR> and prints that '%' symbol.). This is the backtrace that gets printed to the file: It uses the native |
|
Thanks, this looks pretty cool. I have updated the docs and issue template to reflect these changes. |
7bf9e12 to
4d6b4a0
Compare
|
I saw you added the RUST_BACKTACE=full in the user documentation. This isn't technically required anymore. That option is just there for when you need a backtrace on stderr, but since stderr isn't used for backtraces, you don't need that option. Internally, in the panic handler, it forces a backtrace to be written, even when the user hasn't enabled it explicitly :) |
|
Ah thanks! Fixed :) |