8000 config / authentication: permit to call external program for getting … by inemajo · Pull Request #1058 · hrkfdn/ncspot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

config / authentication: permit to call external program for getting … #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2023
Merged

config / authentication: permit to call external program for getting … #1058

merged 3 commits into from
Mar 1, 2023

Conversation

inemajo
Copy link
Contributor
@inemajo inemajo commented Feb 21, 2023

Hi, with this pull request

You can add into your ncspot/config.toml like this:

creds_username = "mylogin"
creds_passeval = "pass my_pass_path_to_spot_password"

Or using any password manager who send your password.to stdout. If a newline is detected it will be automatically removed

@inemajo in 8000 emajo force-pushed the config_adding_passeval_for_credentials branch 2 times, most recently from 0f11e59 to ca6df20 Compare February 28, 2023 18:55
inemajo and others added 2 commits February 28, 2023 22:51
@inemajo @hrkfdn
config / authentication: permit to call external program for getting …
5f5b043 
…credentials

You can add into your ncspot/config.toml like this:

```
creds_username = "mylogin"
creds_passeval = "pass my_pass_path_to_spot_password"
```

Or using any password manager who send your password.to stdout.
If a newline is detected it will be automatically removed
@hrkfdn
Move credential commands into separate structure
ba07e5e 
Also add an option for a username command
@hrkfdn hrkfdn force-pushed the config_adding_passeval_for_credentials branch from ca6df20 to 4bc289a Compare February 28, 2023 23:02
@hrkfdn
Copy link
Owner
hrkfdn commented Feb 28, 2023

Hey @inemajo, I have made some changes to also support username commands and moved the configuration variables into a separate structure. Are you OK with this?

@hrkfdn hrkfdn force-pushed the config_adding_passeval_for_credentials branch from 4bc289a to ff4e98d Compare February 28, 2023 23:04
@inemajo
Copy link
Contributor Author
inemajo commented Mar 1, 2023

Hi @hrkfdn, cool I'm OK thank you

@hrkfdn hrkfdn merged commit c2e030c into hrkfdn:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inemajo @hrkfdn
0