Add initial search to savedata manager #14237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a42923 to
e3c0fe1
Compare
e3c0fe1 to
b050a07
Compare
|
Finally got around to try this. The Search button is a little too off in the corner, not sure where to best put it though. Code looks good, merging. |
|
I suppose I could do what all the cool kids do and hide it and the sorting options in a tiny button with three dots inside it. Though I'm being slightly sarcastic, it might in fact be easier to notice for people that way. -[Unknown] |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a button to type a term, and does a simple search for that term among the list.
Some improvements that would still be good, but don't block usefulness:
Thought this might be an obvious application of #14202, but of course the delayed loading of ginfo made it more complex. That's actually a problem if we expose to accessibility anyway, since
Drawis not really relevant...Still, I think this is a very useful place for UI search. Other candidates:
-[Unknown]