UWP Improvements #17350
UWP Improvements #17350
Conversation
|
This is really cool, thanks for doing this! I'll review it in a bit more detail tomorrow, and will probably end up merging it after the 1.15 release process (we don't yet do official UWP releases anyway). |
|
Thanks man, I really appreciate your time to check this PR, |
|
So apparently I had few things mixed up due to the old builds of windows and lack of information in MS docs API direct accessit will be allowed for direct access using the API that made for UWP (those ends with Get StorageFile with full pathalso functions such as Code formatingfor some reason in VS lines look aligned and good, but in github some of them appear not aligned. PRI had to pull out many changes, let me know if I should re-submit another pull and close this in case this going to cause confusing. |
The good old tabs vs spaces indentation issue, in GitHub a tab is equal to around 8 spaces (IIRC) while in Visual Studio a tab is much less than that. It's kind of annoying to deal with but you get used to it once you know about this. |
- Fixed freespace value - added back BOOTABLE case to BROWSE_FOR_FILE - Fixed fake folder info - Fixed some code formating
Path preview can actually solved within ToVisualString without creating another function, I feel it will cause confusing as both function will be similar.
|
I'll take another look soon, sorry for the long, long delay! |
Replacing NativeMessageReceived with System_PostUIMessage
No problem at all, take your time, let me know if there will be any further changes |
- Better handling for launch items - Resolved code conflicts
This was wrapped before with `#if PPSSPP_PLATFORM(ANDROID)` after it got removed now start to appear in UWP, this should fix it.
|
Alright, this is looking really good now, there are some nice fixes here. Just wondering why indentation is now inconsistent betwee different XML files - some get their tabbing changed in this PR, making diffs hard to read (sure, there are workaround but still) and some don't. With that fixed, I'm happy to merge. |
Those are 'manifest' files, lines were aligned with spaces instead of tabs, so now they look different Old manifestNew manifestHope they are better now after this commit |
|
When looking at the overall PR diff, I still see them with a formatting change. But eh, it's not that important. |
Hi,
Here a suggested changes to improve the UWP version
changes were carefully added to avoid breaking other platforms, it will be applied only for UWP
I don't know what is used exactly in libretro core, so all changes excluded from libretro build
Main changes
layermanagerthese changes may address: #15595 & #16423
Custom memory stick
I used the same UI in Android to make user able to change the location to another place
I did my best to enable this feature without breaking anything else.
Launch options
ppsspp:with support to switch back to the callerppsspp:?cmd="fullpath"orppsspp:?cmd="fullpath"&launchOnExit=targetURIUWP storage layerMajor part of this layer pulled out due to not required by latest windows builds, only builds before 10.0.17134
Features enabled
I enabled some features to make it almost similar to the desktop version such as browse folder
now it will generate logs
near toinside PSP folderinside LOGS folder(not sure if this was enabled before but in case it wasn't)Need to more work [Solved]
Some places still can be better, like the way to detect launch requestI didn't find a better and effective place other than Render (loop) to keep track these requestsit need to be moved to proper place in future.I hope you will find it easy to check and helpful
already tested on XBOX, Desktop without any problem.
Thanks.