Update Matrix/Vector receiver #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1331 1342 +11
=========================================
+ Hits 1331 1342 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors receiver types and function signatures across the quantum, gate, density, and math packages to use pointer semantics for matrices and vectors. Key changes include updating the "Qubit" struct and associated methods, revising gate and density matrix operations, and aligning test files with the new pointer-based APIs.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| quantum/qubit/qubit.go | Refactored Qubit receiver to use a pointer to vector. |
| quantum/gate/gate_test.go | Updated test cases to work with pointer-based matrix types. |
| quantum/gate/gate.go | Modified gate functions and API to return pointer matrices. |
| quantum/density/matrix_test.go | Adjusted density matrix tests for pointer receivers. |
| quantum/density/matrix.go | Changed internal matrix field and related methods. |
| quantum/density/flip.go | Updated channel functions to use pointer matrix types. |
| q_test.go | Modified tests to align with updated matrix APIs. |
| q.go | Updated Q operations to use pointer matrices. |
| math/vector/vector_test.go | Revised vector tests to use pointer-based vectors. |
| math/vector/vector.go | Refactored vector type to a struct with pointer methods. |
| math/matrix/matrix_test.go | Updated matrix tests with pointer-based matrix types. |
| math/matrix/matrix.go | Changed matrix creation and operations to use pointers. |
Comments suppressed due to low confidence (1)
quantum/gate/gate.go:291
- The loop 'for i := range n' is attempting to iterate over an integer value. Replace it with a conventional loop (e.g., 'for i := 0; i < n; i++') to correctly iterate over a range of indices.
for i := range n {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.