8000 Comments: Load more comments when JS is disabled by ChunkyProgrammer · Pull Request #4176 · iv-org/invidious · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Comments: Load more comments when JS is disabled #4176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Comments: Load more comments when JS is disabled #4176

wants to merge 6 commits into from

Conversation

ChunkyProgrammer
Copy link
Contributor
@ChunkyProgrammer ChunkyProgrammer commented Oct 16, 2023 •
edited
Loading

This PR allows for comments to be opened in a new page when viewing repleis/fetching more comments.

Tests (tests written for when JS is disabled but it should probably also be tested with JS enabled for regression testing)

Video comments

  • go to a video page
  • scroll to comments
  • click load comments
  • scroll back to comments
  • click on view reply on a comment (a new page opens with the repleis)
  • click on Load more (a new page opens with the next page of comments)
  • click on the YT link of a comment to make sure the comment that is highlighted is correct

Community:

  • go to a channel page
  • go on the community tab
  • click load more
  • see list of comments
  • click on the YT link of a comment to make sure the comment that is highlighted is correct

Community:

  • go to a channel page
  • go on the community tab
  • clcik view replies
  • click load comments
  • click view replies
  • a new page opens with replies
  • click load more on the new page
  • go back to the previous page and click load more
  • click on the YT link of a comment and make sure that the comment that is highlighted is correct

closes #409
#341

@ChunkyProgrammer ChunkyProgrammer requested a review from a team as a code owner October 16, 2023 17:35
@ChunkyProgrammer ChunkyProgrammer requested review from unixfox and removed request for a team October 16, 2023 17:35
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from fa40d38 to 5515bb6 Compare October 16, 2023 17:41
SamantazFox
SamantazFox reviewed Oct 18, 2023
View reviewed changes
SamantazFox
SamantazFox reviewed Nov 28, 2023
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from b21cbc1 to 72393f3 Compare November 28, 2023 23:05
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from 1288198 to 313b9a9 Compare December 7, 2023 14:38
@github-actions github-actions bot added the stale label Apr 7, 2024
@iv-org iv-org deleted a comment from github-actions bot Apr 7, 2024
@syeopite syeopite removed the stale label Apr 7, 2024
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from 313b9a9 to e5ae2c7 Compare April 29, 2024 19:40
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Jul 29, 2024
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from e5ae2c7 to 8d455be Compare July 29, 2024 01:51
@ChunkyProgrammer
Copy link
Contributor Author

This PR is still working and relevant

@github-actions github-actions bot removed the stale label Jul 29, 2024
SamantazFox
SamantazFox reviewed Aug 8, 2024
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch 2 times, most recently from 35914c6 to e6ca5b5 Compare August 13, 2024 19:10
SamantazFox
SamantazFox reviewed Aug 20, 2024
View reviewed changes
SamantazFox
SamantazFox reviewed Aug 20, 2024
View reviewed changes
SamantazFox
SamantazFox reviewed Aug 20, 2024
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from f7fef18 to 2a012f8 Compare August 24, 2024 22:02
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from 2a012f8 to f65627f Compare October 1, 2024 02:03
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from f65627f to 2a648b0 Compare October 30, 2024 16:57
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from 2a648b0 to 9b995d6 Compare November 17, 2024 18:15
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from 9b995d6 to ddb63ba Compare March 18, 2025 13:08
@ChunkyProgrammer ChunkyProgrammer force-pushed the load-comment-replies-no-js branch from ddb63ba to 14db9c3 Compare June 17, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixfox unixfox Awaiting requested review from unixfox unixfox was automatically assigned from iv-org/developers

@syeopite syeopite Awaiting requested review from syeopite

@SamantazFox SamantazFox Awaiting requested review from SamantazFox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: View comment replies without JS
3 participants
@ChunkyProgrammer @SamantazFox @syeopite
0