use the resolved data in submit #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice good catch. Thank you! @scamden I'm adding you as a collaborator to the repo since you've been contributing to the package. I'm going to keep working on it as well but if you've got my consent to create releases, merge PRs etc if you want too. The way the actions are setup you , it will deploy to NPM with the tag name as the package version any time a new release is created |
|
Oh great! Thanks that's helpful! Are you still feeling good about the library or has it not been quite doing what you'd hoped? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i believe this is the reason we aren't seeing stripped values in the submit eg this issue
Closes #106
@iway1