fix CustomChildComponent remount #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scamden
commented
Jul 19, 2023
| => {}} | ||
| > | ||
| {(fields) => { | ||
| const { isDirty } = useFormState(); |
There was a problem hiding this comment.
i added this to the test and made it work, but maybe the assumption should be that it doesn't? I think hooks strictly speaking are not completely safe to use in a render prop..
spikebrehm
reviewed
Jul 20, 2023
| renderedFields, | ||
| }: { | ||
| renderedFields: RenderedFieldMap<SchemaType>; | ||
| CustomChildrenComponent?: FunctionComponent<RenderedFieldMap<SchemaType>>; |
There was a problem hiding this comment.
is this really a FunctionComponent? isn't it just a function? it's a render prop not a component yeah?
There was a problem hiding this comment.
Oh good point! That's the whole reason for this change lol :)
|
gonna go ahead and merge this since it's a bug fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that having a function as child rendered as a component was causing the whole form to rerender on some kinds of changes. Call the function as a function instead to avoid this bug. Added a test to prove the issue and fixed.
Note: this does mean our custom child has all the limitations of a normal render prop, but I think that should have already been implied. If a true component is needed it can be rendered from within the function.