10000 Marked forks as repositories added as VCS by mnocon · Pull Request #16 · ibexa/ci-scripts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Marked forks as repositories added as VCS #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Marked forks as repositories added as VCS #16

merged 1 commit into from
Aug 12, 2021

Conversation

mnocon
Copy link
Contributor
@mnocon mnocon commented Jun 30, 2021 •
edited
Loading

Follow up to #13
Forks should also be added as VCS repositories, otherwise Composer is unable to find requested branch.

Proof that it works when generating (adds VCS for private or forks repositories, does not add for public repositories).

MacBook-Pro:ci-scripts mareknocon$ bin/travis dependencies:link

 Please enter the number of related Pull Requests [1]:
 > 3

 Link to GitHub PR:
 > https://github.com/ezsystems/ezplatform-admin-ui/pull/1789

 Link to GitHub PR:
 > https://github.com/ezsystems/ezplatform-page-builder/pull/775

 Link to GitHub PR:
 > https://github.com/ezsystems/ezplatform-kernel/pull/208



 [OK] Successfully generated dependencies.json file


MacBook-Pro:ci-scripts mareknocon$ cat dependencies.json
[
    {
        "requirement": "dev-ibx-579-add-location-40 as 3.0.x-dev",
        "repositoryUrl": "https://github.com/micszo/ezplatform-admin-ui",
        "package": "ezsystems/ezplatform-admin-ui",
        "shouldBeAddedAsVCS": true
    },
    {
        "requirement": "dev-ibx-676-fixed-switcher-icons as 1.3.x-dev",
        "repositoryUrl": "https://github.com/ezsystems/ezplatform-page-builder",
        "package": "ezsystems/ezplatform-page-builder",
        "shouldBeAddedAsVCS": true
    },
    {
        "requirement": "dev-ibx_688 as 1.3.x-dev",
        "repositoryUrl": "https://github.com/ezsystems/ezplatform-kernel",
        "package": "ezsystems/ezplatform-kernel",
        "shouldBeAddedAsVCS": false
    }
]

TODO:

1) Make sure it works on Travis

Tested on Travis:
https://app.travis-ci.com/github/ezsystems/ezplatform-page-builder/jobs/530646412#L1180

You can see that a fork dependency has been added correctly: ezsystems/ezplatform-admin-ui#1846

@mnocon mnocon changed the title Included forks as repositories added as VCS Marked forks as repositories added as VCS Aug 11, 2021
@mnocon mnocon marked this pull request as ready for review August 11, 2021 10:30
@mnocon mnocon merged commit 00868f4 into 0.1 Aug 12, 2021
@mnocon mnocon deleted the add-forks-as-vcs branch October 24, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@bogusez bogusez bogusez approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa Awaiting requested review from kacper-wieczorek-ibexa

@micszo micszo Awaiting requested review from micszo 57D5

@pbisaga pbisaga Awaiting requested review from pbisaga

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnocon @tomaszszopinski @bogusez
0