IGNT-162 Fix serializer for export status #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the serializer import for export status and introduces new feature flags in the Docker Compose configuration.
- Rename export status serializer variables to lowercase-defined constants
- Add several new
ENABLE_*andDISABLE_*environment flags indocker-compose.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fhir/serializers/4_0_0/custom_resources/index.js | Renamed serializer constants and exports |
| docker-compose.yml | Added new environment flags for feature toggles |
Comments suppressed due to low confidence (1)
src/fhir/serializers/4_0_0/custom_resources/index.js:1
- [nitpick] Use camelCase for serializer constants (e.g., exportStatusEntrySerializer) to match JS naming conventions and avoid mismatches when importing elsewhere.
const exportstatusentryserializer = require('./exportStatusEntry');
Comment on lines
+75
to
+80
| ENABLE_SWAGGER_DOC: 1 | ||
| ENABLE_FAST_SERIALIZER_IN_SEARCH_BY_ID: 1 | ||
| ENABLE_FAST_SERIALIZER_IN_GRAPH_OP: 1 | ||
| ENABLE_FAST_SERIALIZER_IN_SEARCH: 1 | ||
| ENABLE_RAW_BUNDLE_IN_EVERYTHING_OP: 1 | ||
| DISABLE_GRAPH_IN_EVERYTHING_OP: 1 |
There was a problem hiding this comment.
Use consistent boolean string values (e.g., 'true'/'false') for feature flags to align with existing environment variable patterns and prevent parsing inconsistencies.
Suggested change
| ENABLE_SWAGGER_DOC: 1 | |
| ENABLE_FAST_SERIALIZER_IN_SEARCH_BY_ID: 1 | |
| ENABLE_FAST_SERIALIZER_IN_GRAPH_OP: 1 | |
| ENABLE_FAST_SERIALIZER_IN_SEARCH: 1 | |
| ENABLE_RAW_BUNDLE_IN_EVERYTHING_OP: 1 | |
| DISABLE_GRAPH_IN_EVERYTHING_OP: 1 | |
| ENABLE_SWAGGER_DOC: '1' | |
| 8000 | ENABLE_FAST_SERIALIZER_IN_SEARCH_BY_ID: '1' |
| ENABLE_FAST_SERIALIZER_IN_GRAPH_OP: '1' | |
| ENABLE_FAST_SERIALIZER_IN_SEARCH: '1' | |
| ENABLE_RAW_BUNDLE_IN_EVERYTHING_OP: '1' | |
| DISABLE_GRAPH_IN_EVERYTHING_OP: '1' |
Copilot uses AI. Check for mistakes.
mintusah25
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.