IGNT-162 Fix serializer for export status #1894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the serializer initialization for export status by correcting the serializer name used when requiring the ExportStatusEntry module.
- Renamed the condition check from "ExportStatusEntrySerializer" to "ExportStatusEntry" to match the module in initializeSerializers.
- Updated calls in the output and errors properties to initialize the correct serializer.
Comments suppressed due to low confidence (2)
src/fhir/serializers/4_0_0/custom_resources/exportStatus.js:66
- There appears to be a typo in the class name 'ExportStatusSerialzer'; consider renaming it to 'ExportStatusSerializer' for clarity and consistency.
class ExportStatusSerialzer {
src/fhir/serializers/4_0_0/custom_resources/exportStatus.js:29
- The update from 'ExportStatusEntrySerializer' to 'ExportStatusEntry' is appropriate for matching the required module. Ensure that this naming convention aligns with similar serializer implementations elsewhere in the codebase.
if (serializerName === 'ExportStatusEntry' && !ExportStatusEntry) {
nirbhaykumar1999
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.