8000 claim non rev check for privado id with genesis state by volodymyr-basiuk · Pull Request #250 · iden3/contracts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

claim non rev check for privado id with genesis state #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 16, 2024
Merged

claim non rev check for privado id with genesis state #250

merged 7 commits into from
Aug 16, 2024

Conversation

volodymyr-basiuk
Copy link
Contributor

No description provided.

@coveralls
Copy link
coveralls commented Jul 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10419527445

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 86.412%
Totals Coverage Status
Change from base Build 10419267406: -0.004%
Covered Lines: 749
Relevant Lines: 807
💛 - Coveralls

@volodymyr-basiuk volodymyr-basiuk changed the title WIP: claim non rev check for privado id with genesis state claim non rev check for privado id with genesis state Jul 30, 2024
@volodymyr-basiuk volodymyr-basiuk marked this pull request as ready for review July 30, 2024 13:30
Kolezhniuk
Kolezhniuk previously approved these changes Jul 31, 2024
View reviewed changes
vmidyllic
vmidyllic reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor
@vmidyllic vmidyllic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for @Kolezhniuk PR merge, because it also contains some changes to lib

@vmidyllic vmidyllic requested a review from OBrezhniev August 2, 2024 14:22
vmidyllic
vmidyllic previously approved these changes Aug 16, 2024
View reviewed changes
@vmidyllic vmidyllic merged commit 7bf7c06 into master Aug 16, 2024
5 checks passed
@vmidyllic vmidyllic deleted the feat/privado-chain-validator-revocation branch August 16, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmidyllic vmidyllic vmidyllic approved these changes

@OBrezhniev OBrezhniev Awaiting requested review from OBrezhniev

@Kolezhniuk Kolezhniuk Awaiting requested review from Kolezhniuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@volodymyr-basiuk @coveralls @Kolezhniuk @vmidyllic
0