8000 fix: add gist root id exists check & skip privado 0 gist check by volodymyr-basiuk · Pull Request #255 · iden3/contracts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add gist root id exists check & skip privado 0 gist check #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 20, 2024
Merged

fix: add gist root id exists check & skip privado 0 gist check #255

merged 8 commits into from
Aug 20, 2024

Conversation

volodymyr-basiuk
Copy link
Contributor
@volodymyr-basiuk volodymyr-basiuk commented Aug 19, 2024 •
edited
Loading
  1. for non revocation check: Privado identity should be genesis (skip all others non rev validation)
  2. for genesis check: Privado identity should be with 0 gist root (skip all others genesis root validations)
  3. for genesis check: added idType supported validation

@volodymyr-basiuk volodymyr-basiuk changed the title fix: add gist proof existance check & skip privado 0 gist check fix: add gist root id exists check & skip privado 0 gist check Aug 20, 2024
@volodymyr-basiuk volodymyr-basiuk marked this pull request as ready for review August 20, 2024 10:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10469501916

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 85.979%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/validators/CredentialAtomicQueryValidatorBase.sol 6 9 66.67%
Totals Coverage Status
Change from base Build 10421592471: -0.4%
Covered Lines: 752
Relevant Lines: 813
💛 - Coveralls

ilya-korotya
ilya-korotya reviewed Aug 20, 2024
View reviewed changes
contracts/validators/CredentialAtomicQueryValidatorBase.sol
);
return;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check if the contract support the id type.

s.state.getIdTypeIfSupported(_id);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is checked on getStateInfoById or Exists call

vmidyllic
vmidyllic approved these changes Aug 20, 2024
View reviewed changes
contracts/validators/CredentialAtomicQueryValidatorBase.sol
);
return;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is checked on getStateInfoById or Exists call

@vmidyllic vmidyllic merged commit e97c111 into master Aug 20, 2024
5 checks passed
@vmidyllic vmidyllic deleted the feat/privad-gist-check branch August 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-korotya ilya-korotya ilya-korotya left review comments

@vmidyllic vmidyllic vmidyllic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@volodymyr-basiuk @coveralls @ilya-korotya @vmidyllic
0