-
Notifications
You must be signed in to change notification settings - Fork 34
Deployments #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployments #291
Conversation
Pull Request Test Coverage Report for Build 11386110492Details
💛 - Coveralls |
4395f5e
to
3406366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the lib addresses should be preserved as they are unified. @daveroga what do you think?
@OBrezhniev and why there is no State unified address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
State is not here maybe because ignition files were removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not important to have all the records here as ignition files will not be used for any on-chain upgrades in the future. They are for logging only and duplicated in the outputs.
So nevermind the comment. I approve the pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
State is not here maybe because ignition files were removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not important to have all the records here as ignition files will not be used for any on-chain upgrades in the future. They are for logging only and duplicated in the outputs.
So nevermind the comment. I approve the pr.
No description provided.