8000 Deployments by OBrezhniev · Pull Request #291 · iden3/contracts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deployments #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Deployments #291

merged 7 commits into from
Oct 17, 2024

Conversation

OBrezhniev
Copy link
Member

No description provided.

@coveralls
Copy link
coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11386110492

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.921%

Totals Coverage Status
Change from base Build 11375611981: 0.0%
Covered Lines: 953
Relevant Lines: 1051

💛 - Coveralls

@OBrezhniev OBrezhniev force-pushed the feature/new_deployments branch from 4395f5e to 3406366 Compare October 16, 2024 23:44
@OBrezhniev OBrezhniev marked this pull request as ready for review October 17, 2024 14:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the lib addresses should be preserved as they are unified. @daveroga what do you think?
@OBrezhniev and why there is no State unified address?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

State is not here maybe because ignition files were removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not important to have all the records here as ignition files will not be used for any on-chain upgrades in the future. They are for logging only and duplicated in the outputs.
So nevermind the comment. I approve the pr.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

State is not here maybe because ignition files were removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not important to have all the records here as ignition files will not be used for any on-chain upgrades in the future. They are for logging only and duplicated in the outputs.
So nevermind the comment. I approve the pr.

@AndriianChestnykh AndriianChestnykh merged commit 556b804 into master Oct 17, 2024
5 checks passed
@AndriianChestnykh AndriianChestnykh deleted the feature/new_deployments branch October 17, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0