Release stabilisation fixes: Upgrade IZKPVerifier interface, fix disableContract script, add update EmbeddedZKPVerifer script #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upgrade-embedded-verifier-script
…-embedded-verifier-script # Conflicts: # contracts/package.json
Pull Request Test Coverage Report for Build 11405925645Details
💛 - Coveralls |
…lease-stabilisation-fixes
daveroga
reviewed
Oct 18, 2024
helpers/DeployHelper.ts
Outdated
| await verifier.waitForDeployment(); | ||
| console.log("ZKPVerifierWrapper deployed to:", await verifier.getAddress()); | ||
| console.log("EmbeddedZKPVerifierWrapper.sol deployed to:", await verifier.getAddress()); |
There was a problem hiding this comment.
Normally we put the name of the contract without .sol in these messages for deployment.
contracts/package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@iden3/contracts", | |||
| "description": "Smart Contract library for Solidity", | |||
| "version": "2.4.2", | |||
| "version": "2.4.4", | |||
There was a problem hiding this comment.
Why 2.4.4 instead of 2.4.3?
There was a problem hiding this comment.
It's result of collecting of 3PRs into one, but true, let it be 2.4.3
vmidyllic
approved these changes
Oct 18, 2024
daveroga
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.