Check old Universal Verifier / Embedded Verifier compatibility #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41d99f2 to
4867c33
Compare
Pull Request Test Coverage Report for Build 11498609477Details
💛 - Coveralls |
7d22541 to
2269576
Compare
OBrezhniev
reviewed
Oct 22, 2024
c922feb to
1d24939
Compare
6d2c275 to
daf4638
Compare
| let validatorVerification; | ||
| let validatorContractName; | ||
| let validatorType; | ||
| switch (JSON.parse(request[0]).body.scope[0].circuitId) { |
There was a problem hiding this comment.
This will not work if the request JSON is missing or, even worse, wrongly set. Consider getting circuit name from getSupportedCircuitIds()[0] of ICircuitValidator
helpers/constants.ts
Outdated
There was a problem hiding this comment.
Please check if setProofRequest is properly switched from .env file to this constants.ts
There was a problem hiding this comment.
Yes, it's already switched and takes the unified address of the Universal Verifier from constants. Thanks
I have added now also Circuit ID name in constants.ts that I saw they were in several places.
export const CIRCUIT_ID_MTP_V2 = "credentialAtomicQueryMTPV2OnChain";
export const CIRCUIT_ID_SIG_V2 = "credentialAtomicQuerySigV2OnChain";
export const CIRCUIT_ID_V3 = "credentialAtomicQueryV3OnChain-beta.1";
9dbb857 to
441b59f
Compare
AndriianChestnykh
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check old Universal Verifier backward compatibility with some scripts.
Fill contract addresses and execute:
Fix multi-chain check scripts no need to have PRIVATE_KEY configured
Fix multi-chain check oracle signing address wrong state contract in Polygon networks
Add upgrade script to update validators from verifier requests