refactor: Rewrite community feed as Feed class #7254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7254 +/- ##
========================================
Coverage 88.78% 88.79%
========================================
Files 296 305 +9
Lines 41320 41543 +223
========================================
+ Hits 36687 36889 +202
- Misses 4633 4654 +21 ☔ View full report in Codecov by Sentry. |
rjsparks
reviewed
Nov 14, 2024
| def get_object(self, request, *args, **kwargs): | ||
| email_or_name = kwargs["email_or_name"] | ||
| acronym = kwargs["acronym"] | ||
| clist = lookup_community_list(request, email_or_name, acronym) |
| def __call__(self, request, *args, **kwargs): | ||
| try: | ||
| return super(CommunityFeed, self).__call__(request, *args, **kwargs) | ||
| except MultiplePersonError as err: |
There was a problem hiding this comment.
this is no longer raised in this codepath
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.