fix: versioned href for slides URL #8040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8040 +/- ##
==========================================
+ Coverage 88.78% 88.89% +0.10%
==========================================
Files 296 304 +8
Lines 41320 41302 -18
==========================================
+ Hits 36687 36715 +28
+ Misses 4633 4587 -46 ☔ View full report in Codecov by Sentry. |
|
cc: @alexamirante (for awareness) |
rjsparks
approved these changes
Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends a versioned URL constructed by
DocumentInfo.get_href()instead ofget_versionless_href(). This should avoid cache-related issues when Meetecho updates their slides. It also fixes a bug (which, afaik, has not been encountered) where the latest slides would always be shown, even if a specific version was selected.The comment about why
get_versionless_href()was used appears to be stale - I think it was fixed in #7172, which was committed before any of this ever hit the main branch to begin with. I checked all the uses and do not see any situations where it a slides document (or relatedSessionPresentation) is changed/saved after aSlidesManager()method is called.