feat: new meeting registration implementation #8408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8408 +/- ##
==========================================
- Coverage 88.80% 88.78% -0.02%
==========================================
Files 314 314
Lines 41213 41434 +221
==========================================
+ Hits 36601 36789 +188
- Misses 4612 4645 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennifer-richards
requested changes
Mar 15, 2025
There was a problem hiding this comment.
Looking good. For the record, we discussed out-of-band whether the initial=True branch of the migration utility would be better as a Django migration or done manually, but I think it's better to keep it as it's done here.
I think the names.json needs an update. Would also be good to combine the migrations (i.e., remove them and regenerate)
One other comment inline.
jennifer-richards
approved these changes
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation of meeting registrations. Moved from stats.MeetingRegistration to meeting.Registration and meeting.RegistrationTickets. Also new API and management command, migrate_registrations, to copy MeetingRegistration records to Registration.
This is just the first step in a series. The management command can be called from cron regularly to populate the new table, Registration, from the old. Future commits will migrate all the existing code that uses MeetingRegistration to using Registration. Once that is complete the Registration system can be changed to use the new API, stop running the migration, then remove the old table and API.
This PR replaces #7724