10000 fix: do not list GMT as a meeting time option (#8507) by bkmgit · Pull Request #8681 · ietf-tools/datatracker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: do not list GMT as a meeting time option (#8507) #8681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 20, 2025
Merged

fix: do not list GMT as a meeting time option (#8507) #8681

merged 6 commits into from
Jun 20, 2025

Conversation

bkmgit
Copy link
Contributor
@bkmgit bkmgit commented Mar 16, 2025

Fixes #8507

jennifer-richards
jennifer-richards requested changes Mar 17, 2025
View reviewed changes
Copy link
Member
@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should have a migration to update meetings currently using GMT to use UTC instead. I think that just needs to run Meeting.objects.filter(time_zone="GMT").update(time_zone="UTC").

@rjsparks
Copy link
Member
rjsparks commented Apr 1, 2025

We'll add the migration - but it won't be in this week's release.

@bkmgit
Copy link
Contributor Author
bkmgit commented Apr 1, 2025

Ok. Can do it next week, but please feel free to make the change if it needs to be sooner than that.
8000

jennifer-richards
jennifer-richards previously approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member
@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the migration

@codecov Codecov
Copy link
codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (18cea10) to head (f4146d2).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8681      +/-   ##
==========================================
- Coverage   88.71%   88.70%   -0.01%     
==========================================
  Files         320      320              
  Lines       41793    41787       -6     
==========================================
- Hits        37078    37069       -9     
- Misses       4715     4718       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bkmgit
Copy link
Contributor Author
bkmgit commented Jun 19, 2025

@jennifer-richards thanks.

@jennifer-richards
Copy link
Member

@bkmgit You're welcome, and thank you for the PR!

@jennifer-richards
Merge branch 'main' into fork/bkmgit/8507
ADF2 6f4e3cb 
# Conflicts:
#	ietf/meeting/models.py
@rjsparks rjsparks merged commit f85c1a4 into ietf-tools:main Jun 20, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjsparks rjsparks rjsparks approved these changes

@jennifer-richards jennifer-richards jennifer-richards left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow "GMT" as a time zone choice
3 participants
@bkmgit @rjsparks @jennifer-richards
0