feat(agenda): Agenda meeting materials in overflow menu #8698
Conversation
| label: 'Show meeting materials', | ||
| icon: 'collection', | ||
| href: undefined, | ||
| click: () => showMaterials(item.id), |
There was a problem hiding this comment.
Note the new prop click which causes it to be rendered as a button.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8698 +/- ##
==========================================
- Coverage 88.88% 88.80% -0.08%
==========================================
Files 312 314 +2
Lines 40891 41245 +354
==========================================
+ Hits 36345 36629 +284
- Misses 4546 4616 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Are those test failures real or transient? |
|
@jennifer-richards sadly, real |
|
I would avoid renaming everything from "links" to "menuItems" in the code, other than its use in the dropdown menu, as this is only a mobile thing (desktop is a list of buttons, not a menu). Also, it creates an unnecessary disconnect between the term used in the backend (links) and the frontend. |
| @@ -275,7 +275,7 @@ test.describe('past - desktop', () => { | |||
| const eventButtons = row.locator('.agenda-table-cell-links > .agenda-table-cell-links-buttons') | |||
| if (event.flags.agenda) { | |||
| // Show meeting materials button | |||
| await expect(eventButtons.locator('i.bi.bi-collection')).toBeVisible() | |||
| await expect(eventButtons.locator(`#btn-btn-${event.id}-meeting-materials`)).toBeVisible() | |||
There was a problem hiding this comment.
Yep, just following the convention as link ids are btn-lnk-${item.id}-tar so I made button ids btn-btn-${event.id}-mat
The 'Meeting Materials' button wasn't visible in the overflow menu which mobile / large font sizes use. This adds it.