8000 feat: highlight unexpected state in AD dashboard by rudimatz · Pull Request #8738 · ietf-tools/datatracker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: highlight unexpected state in AD dashboard #8738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2025
Merged

feat: highlight unexpected state in AD dashboard #8738

merged 3 commits into from
Mar 27, 2025

Conversation

rudimatz
Copy link
Contributor
@rudimatz rudimatz commented Mar 26, 2025 •
edited by rjsparks
Loading

Fixes #8550

@codecov Codecov
Copy link
codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (70bf2ae) to head (21c7e8b).
Report is 52 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8738      +/-   ##
==========================================
- Coverage   88.88%   88.81%   -0.07%     
==========================================
  Files         312      314       +2     
  Lines       40891    41252     +361     
==========================================
+ Hits        36345    36637     +292     
- Misses       4546     4615      +69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rjsparks
rjsparks requested changes Mar 27, 2025
View reviewed changes
Copy link
Member
@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - a couple of minor changes suggested

ietf/doc/templatetags/ietf_filters.py Outdated
Comment on lines 493 to 495
return not (
(draft_iesg_state and draft_iesg_state.slug == "idexists")
or (draft_stream_state and draft_stream_state.slug == "sub-pub")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a bit of a logic puzzle for future readers. I suggest this as a clearer way to state it:

    return draft_iesg_state.slug != "idexists" and draft_stream_state is not None and draft_stream_state.slug != "sub-pub"

+/- black formatting

ietf/doc/templatetags/tests_ietf_filters.py Outdated
@@ -14,12 +14,15 @@
ConflictReviewFactory,
BofreqFactory,
StatementFactory,
DocumentFactory,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use WgDraftFactory rather than the bare DocumentFactory - it doesn't make sense to test this against non-ietf-stream documents.

@rjsparks rjsparks merged commit 752bc21 into ietf-tools:main Mar 27, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjsparks rjsparks rjsparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight unexpected WG state for documents in Publication Requested
2 participants
@rudimatz @rjsparks
0