8000 Feature/ruby 3 by tagliala · Pull Request #108 · ifad/chronomodel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/ruby 3 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2021
Merged

Feature/ruby 3 #108

merged 2 commits into from
Jan 15, 2021

Conversation

tagliala
Copy link
Member
@tagliala tagliala commented Jan 14, 2021 •
edited
Loading

@vjt
Copy link
Contributor
vjt commented Jan 14, 2021

🥳

@vjt
Copy link
Contributor
vjt commented Jan 14, 2021

Screenshot 2021-01-14 at 12 34 41

🤑

@tagliala
Copy link
Member Author

Migration

    create_table :projects, comment: 'Ciao', temporal: true do |t|
      t.string :name
      t.integer :country_project_id
      t.string :label, default: ''
    end

Rails 5.2 / Ruby 2.7.2

- COMMENT ON TABLE public.projects IS 'Ciao';
+ COMMENT ON TABLE temporal.projects IS 'Ciao';
...
+ COMMENT ON VIEW public.projects IS '{"comment":"Ciao","temporal":true,"chronomodel":"1.2.2"}';

Rails 6.0 / Ruby 3.0

- COMMENT ON TABLE public.projects IS 'Ciao';
+ COMMENT ON TABLE temporal.projects IS 'Ciao';
...
+ COMMENT ON VIEW public.projects IS '{"comment":"Ciao","temporal":true,"chronomodel":"1.2.2"}';

@tagliala tagliala changed the title [DRAFT] Feature/ruby 3 Feature/ruby 3 Jan 14, 2021
@tagliala tagliala marked this pull request as ready for review January 14, 2021 12:16
@tagliala tagliala requested a review from vjt January 15, 2021 09:53
@vjt
Copy link
Contributor
vjt commented Jan 15, 2021

Tests pass, merging this.

Thank you!

@vjt vjt merged commit 5671f80 into master Jan 15, 2021
@vjt vjt deleted the feature/ruby-3 branch January 15, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjt vjt Awaiting requested review from vjt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagliala @vjt
0