8000 Propose `--skip-proto` flag in build process · Issue #2687 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prop 8000 ose --skip-proto flag in build process #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lumtis opened this issue Aug 2, 2022 · 2 comments · Fixed by #2696
Closed

Propose --skip-proto flag in build process #2687

lumtis opened this issue Aug 2, 2022 · 2 comments · Fixed by #2696
Assignees
@lumtis
Labels
type:request Feature request.
Milestone
Priority

Comments

@lumtis
Copy link
Contributor
lumtis commented Aug 2, 2022

Is your feature request related to a problem or issue you encountered? Please describe.
The current build process when serving a chain always building proto files with the embedded protoc of Ignite
Some project may use their own tool for building proto files like buf but still want to use CLI commands for serving, etc...

Describe the solution you'd like
Adding a flag, like for example --skip-proto, that skips the process of building protofiles and directly build the chain sources.
The flag would be proposed to the two commands running the build process

ignite chain serve --skip-proto
ignite chain build --skip-proto
@lumtis lumtis added the type:request Feature request. label Aug 2, 2022
@lumtis lumtis self-assigned this Aug 3, 2022
@ilgooz
Copy link
Member
ilgooz commented Aug 4, 2022

@robert-zaremba we implemented a caching layer so CLI won't generate code for every module each time there is a file change or when you run the chain build or generate commands.

But for CI purposes, as you suggested before, it makes sense to have a --skip-proto which could be useful in case cache files are not persistent on the CI.

Mentioning you for visibility, as this might be interesting for your use case.

@ilgooz ilgooz added this to the Priority milestone Aug 4, 2022
@lumtis lumtis linked a pull request Aug 4, 2022 that will close this issue
feat(chain): add skip-proto flag #2696
Merged
@robert-zaremba
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumtis lumtis

Labels
type:request Feature request.
Projects
None yet
Milestone
Priority
Development

Successfully merging a pull request may close this issue.

feat(chain): add skip-proto flag ignite/cli
3 participants
@robert-zaremba @ilgooz @lumtis
0