8000 feat(`chain`): add `skip-proto` flag by lumtis · Pull Request #2696 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(chain): add skip-proto flag #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 9, 2022
Merged

feat(chain): add skip-proto flag #2696

merged 7 commits into from
Aug 9, 2022

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Aug 4, 2022 •
edited
Loading

Add flag to skip proto generation.

Always skip proto in network command

@lumtis lumtis linked an issue Aug 4, 2022 that may be closed by this pull request
Propose --skip-proto flag in build process #2687
Closed
@lumtis lumtis self-assigned this Aug 5, 2022
@lumtis lumtis marked this pull request as ready for review August 5, 2022 09:29
@lumtis lumtis requested a review from ilgooz August 9, 2022 08:09
@lumtis
Copy link
Contributor Author
lumtis commented Aug 9, 2022

Updated so skip-proto skip all proto generation. Set back previous logic for Generate and simply don't call Generate if the flag is provided

@ilgooz ilgooz merged commit 7628a9a into develop Aug 9, 2022
@ilgooz ilgooz deleted the feat/skip-proto branch August 9, 2022 08:35
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
feat(chain): add skip-proto flag (ignite#2696)
ee9f371 
* change interface

* add flag

* add option

* add changelog

* refactor from comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@aljo242 aljo242 Awaiting requested review from aljo242

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@tbruyelle tbruyelle Awaiting requested review from tbruyelle

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propose --skip-proto flag in build process
2 participants
@lumtis @ilgooz
0