-
Notifications
You must be signed in to change notification settings - Fork 565
publish
: failure: key not found
#2775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I investigated a bit since the I can confirm the error happens when the What I don't understand is in v0.23 it was the same behavior, so I suppose the address of the coordinator should be a SPN account prior to the publish command, right ? Why it's no longer an account ? IDK! |
Thanks for investigating this In the codebase, at least previously, if no accounts are detected, we check if faucet is enabled. If there is a faucet, which is the case when using spn locally, we first request tokens from the faucet which will create the account |
Maybe the refactoring changed the faucet logic |
Which codebase, spn or cli ? |
In cli/ignite/pkg/cosmosclient/cosmosclient.go Line 493 in 781e90a
|
@lubtd OK you're right, in v0.23, |
I have some stuff today and was planning working on this tomorrow. If you see the issue and the fix is quick, no problem with you tackling this! |
Fix #2775 This change restores the behavior we used to have in 0.23, and which has changed with the refac of cosmosclient with the `node` command feat. Calling the faucet (when it is specically enabled) will ensure the account that broadcasts the tx exists in the target chain. Because the `node` command has a `--generate-only` flag, and because we don't want to create a new account when it's set, this flag is now propagated in the cosmosclient struct. Therefore, the faucet isn't called when the flag is set. This doesn't affect the `network` command because it doesn't use that flag.
Fix #2775 This change restores the behavior we used to have in 0.23, and which has changed with the refac of cosmosclient with the `node` command feat. Calling the faucet (when it is specifically enabled) will ensure the account that broadcasts the tx exists in the target chain. Because the `node` command has a `--generate-only` flag, and because we don't want to create a new account when it's set, this flag is now propagated to the cosmosclient struct. Therefore, the faucet isn't called when the flag is set. This doesn't affect the `network` command because it doesn't use that flag.
Fix #2775 This change restores the behavior we used to have in 0.23, and which has changed with the refac of cosmosclient with the `node` command feat. Calling the faucet (when it is specifically enabled) will ensure the account that broadcasts the tx exists in the target chain. Because the `node` command has a `--generate-only` flag, and because we don't want to create a new account when it's set, this flag is now propagated to the cosmosclient struct. Therefore, the faucet isn't called when the flag is set. This doesn't affect the `network` command because it doesn't use that flag. * test link issue in CL * gh doesn't autolink issues in repo's file * Update changelog.md Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> * Solve TODO: validate tx msgs Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
* fix(cosmosclient): call the faucet prior to create the tx Fix #2775 This change restores the behavior we used to have in 0.23, and which has changed with the refac of cosmosclient with the `node` command feat. Calling the faucet (when it is specifically enabled) will ensure the account that broadcasts the tx exists in the target chain. Because the `node` command has a `--generate-only` flag, and because we don't want to create a new account when it's set, this flag is now propagated to the cosmosclient struct. Therefore, the faucet isn't called when the flag is set. This doesn't affect the `network` command because it doesn't use that flag. * test link issue in CL * gh doesn't autolink issues in repo's file * Update changelog.md Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> * Solve TODO: validate tx msgs * test: cosmosclient.New * test: cosmosclient.WaitForBlockHeight * wip: test cosmosclient.Account * test: cosmosclient.Account * test: improve cosmosclient.WaitForBlockHeight * test: cosmosclient.Address * test: cosmosclient.Status * refac: cosmosclient.Address - dont need to use sdkconfig prefix since we have can just call account.Address(prefix) - improve error message by using GetByName directly * refac: no need for private account func * restore cosmosaccount.Keyring public * style: rename var * add CL entry * Update changelog.md Co-authored-by: Alex Johnson <alex@shmeeload.xyz> * style: var names * merged too fast * style: remove WithWaitBlockDuration option In favor of a parameter in WaitForBlockHeight * oups * use black box testing only Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Fix ignite#2775 This change restores the behavior we used to have in 0.23, and which has changed with the refac of cosmosclient with the `node` command feat. Calling the faucet (when it is specifically enabled) will ensure the account that broadcasts the tx exists in the target chain. Because the `node` command has a `--generate-only` flag, and because we don't want to create a new account when it's set, this flag is now propagated to the cosmosclient struct. Therefore, the faucet isn't called when the flag is set. This doesn't affect the `network` command because it doesn't use that flag. * test link issue in CL * gh doesn't autolink issues in repo's file * Update changelog.md Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> * Solve TODO: validate tx msgs Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
* fix(cosmosclient): call the faucet prior to create the tx Fix ignite#2775 This change restores the behavior we used to have in 0.23, and which has changed with the refac of cosmosclient with the `node` command feat. Calling the faucet (when it is specifically enabled) will ensure the account that broadcasts the tx exists in the target chain. Because the `node` command has a `--generate-only` flag, and because we don't want to create a new account when it's set, this flag is now propagated to the cosmosclient struct. Therefore, the faucet isn't called when the flag is set. This doesn't affect the `network` command because it doesn't use that flag. * test link issue in CL * gh doesn't autolink issues in repo's file * Update changelog.md Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> * Solve TODO: validate tx msgs * test: cosmosclient.New * test: cosmosclient.WaitForBlockHeight * wip: test cosmosclient.Account * test: cosmosclient.Account * test: improve cosmosclient.WaitForBlockHeight * test: cosmosclient.Address * test: cosmosclient.Status * refac: cosmosclient.Address - dont need to use sdkconfig prefix since we have can just call account.Address(prefix) - improve error message by using GetByName directly * refac: no need for private account func * restore cosmosaccount.Keyring public * style: rename var * add CL entry * Update changelog.md Co-authored-by: Alex Johnson <alex@shmeeload.xyz> * style: var names * merged too fast * style: remove WithWaitBlockDuration option In favor of a parameter in WaitForBlockHeight * oups * use black box testing only Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Describe the bug
Some recent changes seem to have broken the publish command.
The command works if a chain has already been published, therefore the issue might be related to creating a coordinator
To reproduce
The text was updated successfully, but these errors were encountered: