8000 Problem with Hello Ignite Cli blog · Issue #2817 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Problem with Hello Ignite Cli blog #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chatton opened this issue Sep 7, 2022 · 5 comments · Fixed by #2819
Closed

Problem with Hello Ignite Cli blog #2817

chatton opened this issue Sep 7, 2022 · 5 comments · Fixed by #2819
Assignees
@tbruyelle
Labels
report

Comments

@chatton
Copy link
chatton commented Sep 7, 2022

Describe the bug

Following the hello ignite blog does result in a functional endpoint.

It looks the RegisterGRPCGatewayRoutes function is not being updated as outlined here in the next blog post.

Updating the function manually to

// RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the module.
func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) {
	types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx))
	// this line is used by starport scaffolding # 2
}

Seems to fix the issue.

To reproduce
Steps to reproduce the behavior:

  1. Follow the blog instructions all the way to the end.

  2. Attempt to access any of the hello module grpc endpoints through the web UI or otherwise
    and it will return a Not Implemented.

curl http://localhost:1317/hello/hello/hello
# {
#  "code": 12,
#  "message": "Not Implemented",
#  "details": [
#  ]
# }

What version are you using?

·
· 🛸 Ignite CLI v0.23.0 is available!
·
· To upgrade your Ignite CLI version, see the upgrade doc: https://docs.ignite.com/guide/install.html#upgrading-your-ignite-cli-installation
·
··
Ignite CLI version:     v0.22.2
Ignite CLI build date:  2022-06-23T16:39:25Z
Ignite CLI source hash: a22808a031b93c0c4065a303edea88bb90be6a10
Your OS:                darwin
Your arch:              arm64
Your go version:        go version go1.18 darwin/arm64
Your uname -a:          Darwin Cians-MBP.fritz.box 21.3.0 Darwin Kernel Version 21.3.0: Wed Jan  5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T6000 arm64
Is on Gitpod:           false
@chatton chatton added the report label Sep 7, 2022
@tbruyelle
Copy link
Contributor

Hey @chatton excuse me but the instructions specifically say that this has to be updated manually, so I'm not sure I follow you.

@tbruyelle tbruyelle self-assigned this Sep 8, 2022
@chatton
Copy link
Author
chatton commented Sep 9, 2022

Hi @tbruyelle, sorry if I'm missing something but I don't see where RegisterGRPCGatewayRoutes is mentioned in the hello cli tutorial. It's mentioned in the follow up Build a blog tutorial, but I don't see the instructions in the Hello, Ingite CLI one.

@tbruyelle
Copy link
Contributor
tbruyelle commented Sep 9, 2022 •
edited
Loading

Oh sorry I misunderstood you were mentioning the hello tutorial, indeed, there's something wrong, the registration has been removed in a recent commit (7c836df). I will check with the team the reason and I'll let you know.

Thank you very much for the report!

@chatton
Copy link
Author
chatton commented Sep 9, 2022

Sorry @tbruyelle sorry if my original description was not clear! I now realise I was referring to it as a blog and then the second tutorial is about building a blog 😅

tbruyelle added a commit that referenced this issue Sep 9, 2022
@tbruyelle
docs(guide/hello): revert grpc registration removal
dae8536 
Fix #2817

There's 2 reasons why the change should be reverted:
- the version that does the registration automatically is not released yet
  (0.24)
- the hello tutorial requires the use of cli 0.22, where the
  registration is always manual.

What could be changed in the 0.24 documentation:
- remove the 0.22 requirement (latest could be used w/o any problem I
  think)
- remove the manual grpc registration.
@tbruyelle tbruyelle mentioned this issue Sep 9, 2022
Merged
tbruyelle added a commit that referenced this issue Sep 9, 2022
@tbruyelle
docs(guide/hello): revert grpc registration removal (#2819)
bd761cc 
Fix #2817

There's 2 reasons why the change should be reverted:
- the version that does the registration automatically is not released yet
  (0.24)
- the hello tutorial requires the use of cli 0.22, where the
  registration is always manual.

What could be changed in the 0.24 documentation:
- remove the 0.22 requirement (latest could be used w/o any problem I
  think)
- remove the manual grpc registration.
@tbruyelle
Copy link
Contributor

@chatton Error fixed, the doc will be deployed soon, thanks again for your report!

Jchicode pushed a commit to Jchicode/cli that referenced this issue Aug 9, 2023
@tbruyelle
docs(guide/hello): revert grpc registration removal (ignite#2819)
5461922 
Fix ignite#2817

There's 2 reasons why the change should be reverted:
- the version that does the registration automatically is not released yet
  (0.24)
- the hello tutorial requires the use of cli 0.22, where the
  registration is always manual.

What could be changed in the 0.24 documentation:
- remove the 0.22 requirement (latest could be used w/o any problem I
  think)
- remove the manual grpc registration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbruyelle tbruyelle

Labels
report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(guide/hello): revert grpc registration removal ignite/cli
2 participants
@tbruyelle @chatton
0