8000 Nightly releases occasionally fail · Issue #3366 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nightly releases occasionally fail #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aljo242 opened this issue Jan 4, 2023 · 5 comments · Fixed by #3368 or #3409
Closed

Nightly releases occasionally fail #3366

aljo242 opened this issue Jan 4, 2023 · 5 comments · Fixed by #3368 or #3409
Assignees
@albttx
Labels
pr:need-review Change request requires peer review. type:error Something isn't working

Comments

@aljo242
Copy link
Contributor
aljo242 commented Jan 4, 2023

Context:

Occasionally, the release-nightly workflow will fail, causing a draft nightly release to be created. If the workflow continues to fail, we end up with multiple draft nightly releases.
@aljo242 aljo242 added type:error Something isn't working pr:need-review Change request requires peer review. labels Jan 4, 2023
tbruyelle added a commit that referenced this issue Jan 4, 2023
@tbruyelle
fix: nightly release
eeecc23 
Fix #3366

The error was related to the upload part, which sometimes works and
sometimes fails. Using a higher retry value might solve the issue.
@tbruyelle tbruyelle mentioned this issue Jan 4, 2023
Merged
@tbruyelle tbruyelle self-assigned this Jan 4, 2023
@aljo242 aljo242 closed this as completed in 8000 #3368 Jan 4, 2023
aljo242 pushed a commit that referenced this issue Jan 4, 2023
@tbruyelle
fix: nightly release (#3368)
faab2f8 
Fix #3366

The error was related to the upload part, which sometimes works and
sometimes fails. Using a higher retry value might solve the issue.

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
@tbruyelle
Copy link
Contributor

The fix faab2f8 is not sufficient https://github.com/ignite/cli/actions/runs/3840420614/jobs/6539455900#step:3:50

@tbruyelle tbruyelle reopened this Jan 4, 2023
@tbruyelle tbruyelle removed their assignment Jan 6, 2023
@aljo242
Copy link
Contributor Author
aljo242 commented Jan 7, 2023

@albttx can you investigate?

@albttx
Copy link
Contributor
albttx commented Jan 9, 2023 •
edited
Loading

The error is

Error: fatal: unable to access 'https://github.com/ignite/cli/': The requested URL returned error: 429

Error 429 is a rate-limiting error 429 Error with too frequent download

From github documentation

When using GITHUB_TOKEN , the rate limit is 1,000 requests per hour per repository.

Here is some options:

  • Pay github to have a better plan
  • Reduce our actions to reduce our calls
  • Move this release nightly as a Schedule action, for example : run every hours, maybe that could help
  • Have an actions to "wait" until we have the rate-limit ok, but that will consume rate-limited requests, might not be a good idea

@tbruyelle
Copy link
Contributor
tbruyelle commented Jan 9, 2023 •
edited
Loading

Move this release nightly as a Schedule action, for example : run every hours, maybe that could help

I like that option. We don't need immediate access to nightly releases, like as soon as a branch is merged to main. This can be scheduled like 1 or 2 times per day.

@aljo242
Copy link
Contributor Author
aljo242 commented Jan 10, 2023

Yeah. We should just do it it "nightly" like the name says lol

@albttx albttx mentioned this issue Jan 11, 2023
Merged
@jeronimoalbi jeronimoalbi mentioned this issue Jun 7, 2023
Closed
Jchicode pushed a commit to Jchicode/cli that referenced this issue Aug 9, 2023
@tbruyelle
fix: nightly release (ignite#3368)
8c66204 
Fix ignite#3366

The error was related to the upload part, which sometimes works and
sometimes fails. Using a higher retry value might solve the issue.

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albttx albttx

Labels
pr:need-review Change request requires peer review. type:error Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: nightly release ignite/cli
chore(ci): release nightly every night ignite/cli
3 participants
@tbruyelle @albttx @aljo242
0