8000 Starport don't retry to build the app when it is serve a second time · Issue #713 · ignite/cli · GitHub

More Web Proxy on the site http://driver.im/

Starport don't retry to build the app when it is serve a second time #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lumtis opened this issue Feb 1, 2021 · 0 comments · Fixed by #714

Assignees

Labels

type:error

Contributor

lumtis commented

Bug from: #712 (comment)

The reason is:

First serve: the app fails to be built
Second serve: the source code is detected as not modified so starport starts the app with the existing binary

The solution I see:

Only save the source code checksum once Starport succeded to start the app, so it will always retry to build it as long as it encounters build error

lumtis added the type:error label

lumtis self-assigned this

lumtis mentioned this issue

fix: rebuild binary if it has been deleted or modified #712

Merged

lumtis linked a pull request

that will close this issue

fix: no rebuild on second serve #714

Merged

lumtis closed this as completed in #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0