8000 fix: no rebuild on second serve by lumtis · Pull Request #714 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: no rebuild on second serve #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2021
Merged

fix: no rebuild on second serve #714

merged 2 commits into from
Feb 2, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Feb 1, 2021

Remove fromHasDirChecksumChanged from dirchange the side effects, it doesn't save the checksum anymore.

Checksums of the source and config are only saved once the app is built and initialized

@lumtis lumtis requested review from fadeev and ilgooz as code owners February 1, 2021 13:11
@lumtis lumtis linked an issue Feb 1, 2021 that may be closed by this pull request
Starport don't retry to build the app when it is serve a second time #713
Closed
fadeev
fadeev approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lumtis lumtis merged commit dd4afdd into develop Feb 2, 2021
@lumtis lumtis deleted the fix/no-build branch February 2, 2021 09:40
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
fix: no rebuild on second serve (ignite#714)
c228c10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starport don't retry to build the app when it is serve a second time
3 participants
@lumtis @fadeev @ilgooz
0