8000 refactor!: remove react frontend + re-enable disabled integration tests by julienrbrt · Pull Request #4744 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor!: remove react frontend + re-enable disabled integration tests #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 3, 2025

Conversation

julienrbrt
Copy link
Member

ref: ignite/web#292
ref: #4414

@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:templates component:configs component:cmd type:services Service-related issues. type:internal component:packages labels Jun 27, 2025
@julienrbrt julienrbrt mentioned this pull request Jun 27, 2025
3 tasks
Copy link
Contributor
github-actions bot commented Jun 27, 2025

Visit the preview URL for this PR (updated for commit 0c77a85):

https://igntservices-docs--pr4744-julien-react-ph6etpjp.web.app

(expires Tue, 08 Jul 2025 16:15:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@julienrbrt julienrbrt marked this pull request as ready for review June 27, 2025 09:58
@Pantani
Copy link
Collaborator
Pantani commented Jun 30, 2025

can you also delete

type Hooks struct {
?

@julienrbrt julienrbrt marked this pull request as draft June 30, 2025 19:11
@julienrbrt
Copy link
Member Author

Turns out the composable index.ts isn't valid, making the frontend not work.

@julienrbrt julienrbrt marked this pull request as ready for review July 1, 2025 15:14
@julienrbrt julienrbrt requested a review from clockworkgr as a code owner July 1, 2025 15:56
@julienrbrt julienrbrt enabled auto-merge (squash) July 1, 2025 17:12
Copy link
Collaborator
@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@julienrbrt julienrbrt merged commit d1bf508 into main Jul 3, 2025
45 checks passed
@julienrbrt julienrbrt deleted the julien/react branch July 3, 2025 16:18
@julienrbrt
Copy link
Member Author

@mergify backport release/v28.x.y

Copy link
Contributor
mergify bot commented Jul 3, 2025

backport release/v28.x.y

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 3, 2025
…ts (#4744)

* refactor!: remove react frontend + re-enable disabled integration tests

* deprecate command and no-op it

* lint

* bump web to v1.0.8

* remove hooks

* improvements

* update index.ts.tpl

* fix

* improve ux

* add pnpm instructions

* fixes

* fix integration test

* rename

* uncomment other test

* updates

---------

Co-authored-by: Danilo Pantani <danpantani@gmail.com>
(cherry picked from commit d1bf508)

# Conflicts:
#	docs/docs/03-clients/04-react.md
#	go.mod
#	go.sum
#	ignite/cmd/generate.go
#	ignite/cmd/generate_hooks.go
#	ignite/cmd/scaffold_react.go
#	ignite/config/chain/base/config.go
#	ignite/config/chain/config.go
#	ignite/pkg/cosmosgen/cosmosgen.go
#	ignite/services/chain/generate.go
#	ignite/services/scaffolder/scaffolder.go
#	integration/app.go
#	integration/client.go
#	integration/cosmosgen/bank_module_test.go
#	integration/cosmosgen/cosmosgen_composables_test.go
#	integration/cosmosgen/cosmosgen_hooks_test.go
#	integration/cosmosgen/custom_module_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:docs Documentation additions or improvements. component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0