8000 feat(network): disable create command for Launchpad apps by ilgooz · Pull Request #586 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(network): disable create command for Launchpad apps #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 21, 2020
Merged

feat(network): disable create command for Launchpad apps #586

merged 4 commits into from
Dec 21, 2020

Conversation

ilgooz
Copy link
Member
@ilgooz ilgooz commented Dec 21, 2020

fixes #584.

@ilgooz ilgooz requested review from fadeev and lumtis as code owners December 21, 2020 08:44
@fadeev
Copy link
Contributor
fadeev commented Dec 21, 2020

I like this functionality, but how do we detect Launchpad/Stargate? Am I correct in understanding that we check for Tendermint's version?

https://github.com/tendermint/starport/blob/develop/starport/pkg/cosmosver/cosmosver.go#L25

If it's v0.34.0, we just assume Stargate.

@ilgooz
Copy link
Member Author
ilgooz commented Dec 21, 2020

@fadeev yep, that' correct. But we can improve this further by checking for Cosmos version to be >= v0.40. Wdyt?

@fadeev
Copy link
Contributor
fadeev commented Dec 21, 2020 •
edited
Loading

The issue I have with this approach is that a chain can have Tendermint <= v0.33, but use commit hash of a newer version. I believe it's dangerous to prevent Starport from trying to build a chain. It might be better to try and fail, and then explain the failure than not trying in the first place.

@ilgooz
Copy link
Member Author
ilgooz commented Dec 21, 2020

Checking docs to confirm,it seems that pseudo versions constructed by using the latest tag available in the repo. Considering this, we should never face with a version like v0.33-xxx in go.mod for recent Stargate apps.

On the other hand, we can still first try to init the app and see if it fails to determine the version but in this case we might also catch some false negatives.

@ilgooz
improve sdk version detection logic
1d84767 
instead of comparing by == we now compare by >= which makes it possible
to determine versions of even newer sdk releases.
@ilgooz
Copy link
Member Author
ilgooz commented Dec 21, 2020 •
edited
Loading

I've just switched to semver.Compare to compare versions, I can confirm that this works smoothly with Go's pseudo versions. But still this doesn't support older chains that has a version like Tendermint <= v0.33.

@ilgooz ilgooz marked this pull request as draft December 21, 2020 10:13
@ilgooz
fix
40a6bda 
lowered sdk version to v0.39.99 to be able to support rc versions of
v0.40.0.
@ilgooz ilgooz marked this pull request as ready for review December 21, 2020 10:38
fadeev
fadeev previously approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilgooz
Copy link
Member Author
ilgooz commented Dec 21, 2020

@fadeev I updated the docs in f35bae4. 📜 But had to lower case the message to avoid related linter error.

@ilgooz ilgooz requested a review from fadeev December 21, 2020 11:08
@ilgooz ilgooz merged commit 6dfa294 into develop Dec 21, 2020
@ilgooz ilgooz deleted the feat/disable-lp branch December 21, 2020 11:18
faddat added a commit to faddat/starport that referenced this pull request Jan 7, 2021
@faddat
Merge https://github.com/tendermint/starport into sos-lite
12c1573 
# By vms (85) and others
# Via GitHub (23) and others
* https://github.com/tendermint/starport: (276 commits)
  refactor: use a fixed-name dir for Starport Network chain sources (ignite#597)
  Update devices.yml (ignite#616)
  refactor: set chaincmd commands as version agnostic (ignite#614)
  feature(network): show errors from appd binary (ignite#506)
  refactor: use stable version of Starport in docs (ignite#610)
  refactor: package for blockchain application commands (ignite#583)
  refactor: cleanup home files (ignite#595)
  feat(pkg/gomodulepath): add tests for paths with versions
  docs: install.md (ignite#602)
  fix: semantic-pr
  fix: determining version number in go paths (ignite#598)
  docs: update readme with a link to v0.13 video (ignite#593)
  diable snapcraft
  ap get update
  fix: changelog small fix (ignite#588)
  Update changelog.md (ignite#587)
  feat(network): disable create command for Launchpad apps (ignite#586)
  refactor(docs): change 'pulling blockchain' to 'fetching source code' (ignite#585)
  Update version of tendermint/vue (ignite#582)
  fix: integration tests (ignite#581)
  ...

# Conflicts:
#	.github/workflows/pi-image.yml
#	.pi/starport.json
#	go.mod
#	go.sum
#	starport/templates/app/launchpad/.github/workflows/build.yml.plush
#	starport/templates/app/launchpad/.github/workflows/pi.yml.plush
#	starport/templates/app/launchpad/.pi/image.bash.plush
#	starport/templates/app/launchpad/.pi/pibuild.json.plush
#	starport/templates/app/launchpad/.pi/{{appName}}d.service.plush
#	starport/ui/package-lock.json
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
feat(network): disable create command for Launchpad apps (ignite#586)
017c380 
* feat(network): disable create command for Launchpad apps

fixes ignite#584.

* improve sdk version detection logic

instead of comparing by == we now compare by >= which makes it possible
to determine versions of even newer sdk releases.

* fix

lowered sdk version to v0.39.99 to be able to support rc versions of
v0.40.0.

* docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@lumtis lumtis Awaiting requested review from lumtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(network): disable create command for Launchpad apps
2 participants
@ilgooz @fadeev
0