refactor: update Stargate version to v0.40.0 #622
Conversation
There was a problem hiding this comment.
@ltacker do we need to update our SDK version for Stargate after this change? I'm not sure that the version we use contains changes from cosmos/cosmos-sdk#7840.
|
@fadeev @ltacker this PR is ready to be reviewed/merged except that Relayer is not yet working. At Relayer's side, a new version that upgrades to |
There was a problem hiding this comment.
Very nice! serve works on both RC and release. gaia serves and launches out of the box. We can add relayer support in a minor release once it's working fine.
The only cosmetic change I would make is:
Cosmos SDK Stargate v0.40.0 (or above)
And:
Cosmos SDK Stargate v0.40.0 (pre-release)
|
I guess Relayer isn't completely migrated to v0.40.0 yet, I can see some failing checks here. Let's wait for a while for it to get fixed. Would you guys like to merge this PR anyway and correct the Relayer's version once it is ready? |
| // WithSecondaryCLI provides the secondary CLI name for the blockchain. | ||
| // this is useful for Launchpad applications since it has two different binaries but | ||
| // not needed by Stargate applications. | ||
| func WithSecondaryCLI(cliCmd string) Option { |
There was a problem hiding this comment.
I prefer to keep an explicit name that we are using Launchpad personally. Not very relevant though
There was a problem hiding this comment.
Let me address this in another PR. 👍
… sos-lite * 'develop' of https://github.com/tendermint/starport: refactor: update Stargate version to v0.40.0 (#622) refactor(services/chain): refactor initialization with New() (#621)
… rollback-and-merge * 'develop' of https://github.com/tendermint/starport: chore: change Gitpod prompt workdir (#636) refactor: standardize --home option usage (#615) refactor: update Stargate version to v0.40.0 (#622) refactor(services/chain): refactor initialization with New() (#621)
* Remove workaround * Update cosmos version * Update templates * migrate to SDK version of v0.40.0 * migrate x/client * fix integration test * update relayer to 1daec66 * support both v0.40.0 and v0.40.0-rc-X versions of Stargate * linter * template: fix client cmd tx * fix relayer * docs * docs Co-authored-by: İlker Göktuğ ÖZTÜRK <ilkergoktugozturk@gmail.com>
edit:
We have decided to directly migrate to v0.40 in this PR.
--
Remove the RegisterTxService since the necessary since the necessary PR has been merged.
This is necessary for #615 to not depend on a fixed home directory.