10000 feat(cmd): build proto in build cmd by ilgooz · Pull Request #667 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cmd): build proto in build cmd #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2021
Merged

feat(cmd): build proto in build cmd #667

merged 2 commits into from
Jan 22, 2021

Conversation

ilgooz
Copy link
Member
@ilgooz ilgooz commented Jan 21, 2021

Seems like standalone starport build command wasn't building proto. This PR solves that.

@ilgooz ilgooz requested review from fadeev and lumtis as code owners January 21, 2021 06:21
fadeev
fadeev approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilgooz ilgooz merged commit 6c8d1cf into develop Jan 22, 2021
@ilgooz ilgooz deleted the feat/build-pb-cmd branch January 22, 2021 07:38
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
feat(cmd): build proto in build cmd (ignite#667)
2a6a8a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@lumtis lumtis Awaiting requested review from lumtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilgooz @fadeev
0