feat(config): make binary name customizable #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for Stargate. this introduces a new top level prop called `binary` in the `config.yml`.
d2a0a45 to
14828ad
Compare
|
This PR just makes it possible to change binary names. Compiling binaries from custom main pkg paths will be done by configuring the incoming |
|
So, if I have |
|
There is a tiny issue in that if I set the binary, it rebuilds, but if I change it, while |
|
This should be good to go for reviewing. 👍 |
fadeev
previously approved these changes
Jan 25, 2021
lumtis
approved these changes
Jan 26, 2021
faddat
added a commit
that referenced
this pull request
Jan 27, 2021
* feat: gh pages automation (#689) * Create pages.yml gh pages automation for stargate * Create pages.yml launchpad * Update readme.md.plush Update stargate readme * Update readme.md.plush directions and usage info for gh pages action * feat(serve): chain state persistence and chain upgrade (#673) * Change command proposition (#694) * feat(config): make binary name customizable (#675) * feat(config): make binary name customizable for Stargate. this introduces a new top level prop called `binary` in the `config.yml`. * fix merge * fix lint * fix merge * move binary prop under build * feat(proto): automatically include third party proto (#685) * feat(proto): automatically include third party proto * removed third party proto paths from the scaffold (third_party/proto and proto/cosmos). * removed third party proto now automatically included during code generation by using Go's module system. (not by a dark magic). * for now scaffolded apps only needs third party protos from Cosmos SDK itself, keep in mind that SDK has a `go.mod` thereof it was possible to use Go's module system to get its proto files (which is `proto/` and `third_party/proto/`). BE AWARE that: * if scaffolded apps at some point require some other third party protos from different repos that also have `go.mod`s, we can implement another feature that reads Git urls of these repos from the `proto` section of config.yml` and easily access their protos. FUTURE NOTE, following posibilities will occur: * third party added to `config.yml` might be imported by the app's `go.mod` * third party added to `config.yml` might not be imported by the app's `go.mod`. this also requires version of the third party to be defined in the `config.yml`. * relative paths of proto dirs needed under these third party proto repos must be defined in the `config.yml` as well. * keep in mind conflicting proto files with the same proto and Go package name. * proto repos that does not have a `go.mod` (means not a Go project) still can be manually downloaded and moved under `proto_vendor` or `third_party/proto` (supported for backwards compability) paths. as it is easily posible to use proto files from Go projects, supporting non-Go ones requires some additional effort of developing a minimal package manager for proto since it is not possible to relay this work to Go's module system anymore. * tidy * rm another unused * docs * gitpod: fix protoc installation & make sure to global proto can be resolved * break Gitpod cache * maybe Gitpod removes hidden files in pre-built workspaces * gitpod: install protoc via brew * fix gitpod ~/home is not persistent, so use a Dockerfile * fix gitpod Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* feat(config): make binary name customizable for Stargate. this introduces a new top level prop called `binary` in the `config.yml`. * fix merge * fix lint * fix merge * move binary prop under build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for Stargate.
this introduces a new top level prop called
binaryin theconfig.yml.