8000 fix: type scaffolding fails if there is no vue dir by lumtis · Pull Request #719 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: type scaffolding fails if there is no vue dir #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2021
Merged

fix: type scaffolding fails if there is no vue dir #719

merged 2 commits into from
Feb 3, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Feb 3, 2021

Skip the frontend modification if the required path is not found instead of returning an error

@lumtis lumtis requested review from fadeev and ilgooz as code owners February 3, 2021 10:06
@lumtis lumtis linked an issue Feb 3, 2021 that may be closed by this pull request
fix: type scaffolding fails if there is no vue dir #708
Closed
fadeev
fadeev approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ilgooz
ilgooz approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member
@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilgooz ilgooz merged commit e877642 into develop Feb 3, 2021
@ilgooz ilgooz deleted the fix/no-vue-dir branch February 3, 2021 11:56
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
fix: type scaffolding fails if there is no vue dir (ignite#719)
2facf69 
* Skip frontend generation

* Remove spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: type scaffolding fails if there is no vue dir
3 participants
@lumtis @fadeev @ilgooz
0