8000 feat: scaffold transactions using MsgServer convention by lumtis · Pull Request #725 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: scaffold transactions using MsgServer convention #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 5, 2021
Merged

feat: scaffold transactions using MsgServer convention #725

merged 15 commits into from
Feb 5, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Feb 4, 2021 •
edited
Loading

When adding types starport type .... it scaffolds transactions with the MsgServer convention:

service Msg {
  ...
}

type command includes a flag --legacy to use the old type generation without services creation.
This option is automatically used for old scaffolded code.

@lumtis lumtis linked an issue Feb 4, 2021 that may be closed by this pull request
Scaffold services for transactions (MsgServer) #717
Closed
@lumtis lumtis marked this pull request as ready for review February 4, 2021 16:15
@lumtis lumtis requested review from fadeev and ilgooz as code owners February 4, 2021 16:15
fadeev
fadeev previously approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ilgooz
ilgooz approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member
@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@lumtis lumtis requested a review from fadeev February 5, 2021 06:55
@lumtis
Copy link
Contributor Author
lumtis commented Feb 5, 2021

@fadeev Added ID as result of CreateFoo since your last review

fadeev
fadeev approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lumtis lumtis merged commit 711dc5b into develop Feb 5, 2021
@lumtis lumtis deleted the feat/msg_server branch February 5, 2021 07:43
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
feat: scaffold transactions using MsgServer convention (ignite#725)
2e2913b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaffold services for transactions (MsgServer)
3 participants
@lumtis @fadeev @ilgooz
0