8000 fix(serve): default home deleted when starting app with custom home by lumtis · Pull Request #778 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(serve): default home deleted when starting app with custom home #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2021
Merged

fix(serve): default home deleted when starting app with custom home #778

merged 2 commits into from
Feb 22, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Feb 22, 2021

When running Stargate app all logic involving CLIHome should use the same value as Home

@lumtis lumtis requested review from fadeev and ilgooz as code owners February 22, 2021 14:08
@lumtis lumtis linked an issue Feb 22, 2021 that may be closed by this pull request
Starting a chain with a custom homedir delete the default homedir #777
Closed
fadeev
fadeev approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilgooz ilgooz merged commit 08d9d9c into develop Feb 22, 2021
@ilgooz ilgooz deleted the fix/home-delete branch February 22, 2021 15:13
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis @ilgooz
fix(services/chain): CLI Home (ignite#778)
c329236 
Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starting a chain with a custom homedir delete the default homedir
3 participants
@lumtis @fadeev @ilgooz
0