fix: don't run the linter on non code changes #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barriebyron
approved these changes
Mar 5, 2021
ilgooz
reviewed
Mar 5, 2021
| - name: Set up Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: "1.16" |
There was a problem hiding this comment.
1.16 is the required version now for Starport. Should we rollback this change?
There was a problem hiding this comment.
The linter should be a prebuilt binary. You don't need to install go I believe
There was a problem hiding this comment.
Tested with #819, seems like removing version is not a problem indeed. While we were using the alpha version of 1.16, it was somewhat required to manage Go installation ourselves because linter was not able to use non stable releases. I think the reason is the linter somehow uses go cmd under the hood or depends on a Go installation in some other way.
ilgooz
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.