8000 refactor(type): use uint64 for id and encode it in the store in big endian by lumtis · Pull Request #848 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(type): use uint64 for id and encode it in the store in big endian #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 12, 2021
Merged

refactor(type): use uint64 for id and encode it in the store in big endian #848

merged 9 commits into from
Mar 12, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Mar 12, 2021

Use uint64 for the type of id for auto-incremented types.

Store them with big-endian encoding so that the types are in increasing order when listing them.

Prevent querying a type that doesn't exist.

@lumtis lumtis requested review from fadeev and ilgooz as code owners March 12, 2021 09:30
@lumtis lumtis requested a review from clockworkgr March 12, 2021 09:30
@lumtis lumtis linked an issue Mar 12, 2021 that may be closed by this pull request
Store types (with autoincrement ID) using big endian for ordering #830
Closed
@lumtis lumtis marked this pull request as draft March 12, 2021 09:46
@lumtis lumtis marked this pull request as ready for review March 12, 2021 10:28
fadeev
fadeev approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ilgooz ilgooz merged commit e2e3502 into develop Mar 12, 2021
@ilgooz ilgooz deleted the refactor/id-uint64 branch March 12, 2021 13:02
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
refactor(type): use uint64 for id and encode it in the store in big e…
05d9906 
…ndian (ignite#848)

* Change id to uint64

* Fixes

* Fixes

* Refactor for legacy

* Fix legacy

* Last fixes

* Fix sprintf

* starport/templates/typed/stargate_legacy/x/{{moduleName}}/handler_{{typeName}}.go.plush
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

@clockworkgr clockworkgr Awaiting requested review from clockworkgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store types (with autoincrement ID) using big endian for ordering
3 participants
@lumtis @fadeev @ilgooz
0