8000 fix: prevent using invalid name for type/packet/message by lumtis · Pull Request #849 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix: prevent using invalid name for type/packet/message #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2021
Merged

fix: prevent using invalid name for type/packet/message #849

merged 5 commits into from
Mar 13, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Mar 12, 2021

Prevent using a name that would generate an incorrect code

@lumtis lumtis requested review from fadeev and ilgooz as code owners March 12, 2021 12:56
@lumtis lumtis linked an issue Mar 12, 2021 that may be closed by this pull request
Investigate all possible forbidden name for type/message/packet and prevent using them #831
Closed
@ilgooz ilgooz merged commit 85fb3a8 into develop Mar 13, 2021
@ilgooz ilgooz deleted the fix/type-invalid-name branch March 13, 2021 05:16
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
fix: prevent using invalid name for type/packet/message (ignite#849)
534e30f 
* Forbidden type name

* Rename type to component

* Create component file

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate all possible forbidden name for type/message/packet and prevent using them
3 participants
@lumtis @fadeev @ilgooz
0